Skip to content
This repository was archived by the owner on Apr 28, 2026. It is now read-only.

fix(ci): Temporarily skip namespaced-actions impacted BATS cases - #773

Merged
elizabethhealy merged 1 commit into
mainfrom
dspx-2540-disable-action-tests-requiring-namespace
Mar 11, 2026
Merged

fix(ci): Temporarily skip namespaced-actions impacted BATS cases#773
elizabethhealy merged 1 commit into
mainfrom
dspx-2540-disable-action-tests-requiring-namespace

Conversation

@elizabethhealy

@elizabethhealy elizabethhealy commented Mar 11, 2026

Copy link
Copy Markdown
Member

Highlights

  • Temporary Test Disablement: Several BATS end-to-end tests related to actions, obligations, registered resources, and subject mappings have been temporarily skipped.
  • Reason for Skipping: The tests are failing in CI due to recent changes impacting 'namespaced-actions', specifically affecting action resolution, flag handling, and validation logic.
  • Impact on CI: This change is a temporary measure to unblock the CI pipeline while the underlying issues with namespaced actions are addressed.

Successful run with changes: https://github.com/opentdf/platform/actions/runs/22972856676/job/66693893731?pr=3130

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request temporarily disables a set of end-to-end BATS tests across various components (actions, obligations, registered resources, and subject mappings). These tests are currently failing in the CI environment due to recent changes related to "namespaced-actions," which have impacted action resolution, flag handling, and validation logic. Skipping these tests is a temporary measure to unblock the CI pipeline while the underlying issues are investigated and resolved.

Highlights

  • Temporary Test Disablement: Several BATS end-to-end tests related to actions, obligations, registered resources, and subject mappings have been temporarily skipped.
  • Reason for Skipping: The tests are failing in CI due to recent changes impacting 'namespaced-actions', specifically affecting action resolution, flag handling, and validation logic.
  • Impact on CI: This change is a temporary measure to unblock the CI pipeline while the underlying issues with namespaced actions are addressed.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • e2e/actions.bats
    • Skipped "Create a new custom action - Good" test.
    • Skipped "Create a new action - Bad" test.
    • Skipped "Get an action - Good" test.
    • Skipped "List actions" test.
    • Skipped "Update action" test.
    • Skipped "Delete action - good" test.
  • e2e/obligations.bats
    • Skipped "Create an obligation value with triggers - JSON Array - Success" test.
    • Skipped "Create an obligation value with triggers - JSON File - Success" test.
    • Skipped "Update obligation values with triggers - Success" test.
    • Skipped "Create an obligation trigger - Required Only - IDs - Success" test.
    • Skipped "Create an obligation trigger - Required Only - FQNs - Success" test.
    • Skipped "Create an obligation trigger - Optional Fields - Success" test.
    • Skipped "Create an obligation trigger - Same tuple different client IDs - Success" test.
    • Skipped "Delete an obligation trigger - Good" test.
    • Skipped "List obligation triggers - No filters" test.
    • Skipped "List obligation triggers - Limit and Offset" test.
    • Skipped "List obligation triggers - Filter by Namespace ID" test.
    • Skipped "List obligation triggers - Filter by Namespace FQN" test.
  • e2e/registered-resources.bats
    • Skipped "Create a registered resource value - Good" test.
    • Skipped "Get a registered resource value - Good" test.
    • Skipped "List registered resource values - Good" test.
    • Skipped "Update registered resource values" test.
  • e2e/subject-mapping.bats
    • Skipped "Update a subject mapping" test.
Activity
  • No specific activity (comments, reviews, progress) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request temporarily disables a number of BATS e2e tests that are failing due to recent changes related to namespaced actions. This is a reasonable short-term solution to unblock the CI pipeline. My main feedback is to add tracking issue numbers to the skip messages to ensure these tests are not forgotten and can be re-enabled once the underlying issues are resolved. I've added comments in each affected file with a suggestion.

Comment thread e2e/actions.bats
Comment thread e2e/obligations.bats
Comment thread e2e/registered-resources.bats
Comment thread e2e/subject-mapping.bats
@elizabethhealy
elizabethhealy marked this pull request as ready for review March 11, 2026 20:32
@elizabethhealy
elizabethhealy requested a review from a team as a code owner March 11, 2026 20:32
@github-actions

Copy link
Copy Markdown

@elizabethhealy
elizabethhealy merged commit 633728a into main Mar 11, 2026
22 checks passed
@elizabethhealy
elizabethhealy deleted the dspx-2540-disable-action-tests-requiring-namespace branch March 11, 2026 20:58
alkalescent pushed a commit that referenced this pull request Mar 31, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.30.0](v0.29.0...v0.30.0)
(2026-03-31)


### Features

* **core:** Add optional namespace flag for subject mappings and
condtion sets ([#779](#779))
([9e849c4](9e849c4))
* **core:** add scope support for client creds
([#752](#752))
([9ca9e43](9ca9e43))
* **core:** migrate registered resources
([#772](#772))
([2b49a7d](2b49a7d))
* **core:** optional namespace in actions commands and re-enable
actions/RR tests ([#775](#775))
([29a2eb1](29a2eb1))
* **core:** support namespaced registered resources
([#767](#767))
([4d786b5](4d786b5))


### Bug Fixes

* **ci:** Temporarily skip namespaced-actions impacted BATS cases
([#773](#773))
([633728a](633728a))
* **core:** bump toolchain to go 1.24.13
([#747](#747))
([6804b93](6804b93))
* **core:** disable RR E2E tests
([#768](#768))
([0821b8c](0821b8c))
* **core:** make namespacing registered resources optional
([#785](#785))
([8e6eb31](8e6eb31))
* **core:** refactor `ListAttributesValues` to use `Get`
([#769](#769))
([a82f7b7](a82f7b7))
* **core:** unsafe update result output values order
([#759](#759))
([baeba0f](baeba0f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants